Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>
This commit is contained in:
Marek Schmitt 2025-03-01 16:52:01 +01:00 committed by GitHub
parent e105468d70
commit cd974d00c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 6 additions and 6 deletions

View File

@ -18,4 +18,4 @@
#define HAL_USE_I2C TRUE #define HAL_USE_I2C TRUE
#include_next <halconf.h> #include_next <halconf.h>

View File

@ -8,7 +8,6 @@
}, },
"diode_direction": "COL2ROW", "diode_direction": "COL2ROW",
"encoder": { "encoder": {
"enabled": true,
"rotary": [ "rotary": [
{"pin_a": "A0", "pin_b": "A1"} {"pin_a": "A0", "pin_b": "A1"}
] ]
@ -17,6 +16,7 @@
"bootmagic": true, "bootmagic": true,
"command": false, "command": false,
"console": false, "console": false,
"encoder": true,
"extrakey": true, "extrakey": true,
"mousekey": false, "mousekey": false,
"nkro": true, "nkro": true,
@ -118,7 +118,7 @@
"pin": "B3" "pin": "B3"
}, },
"layouts": { "layouts": {
"LAYOUT_numpad_4x4": { "LAYOUT": {
"layout": [ "layout": [
{"matrix": [0, 3], "x": 3, "y": 0}, {"matrix": [0, 3], "x": 3, "y": 0},
{"matrix": [1, 0], "x": 0, "y": 1}, {"matrix": [1, 0], "x": 0, "y": 1},

View File

@ -29,7 +29,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
* 1 2 3 0 * 1 2 3 0
* *
*/ */
[0] = LAYOUT_numpad_4x4( [0] = LAYOUT(
RGB_MOD, RGB_MOD,
KC_P7, KC_P8, KC_P9, RGB_TOG, KC_P7, KC_P8, KC_P9, RGB_TOG,
KC_P4, KC_P5, KC_P6, KC_NUM, KC_P4, KC_P5, KC_P6, KC_NUM,

View File

@ -1 +1 @@
ENCODER_MAP_ENABLE = yes ENCODER_MAP_ENABLE = yes

View File

@ -19,4 +19,4 @@
#include_next <mcuconf.h> #include_next <mcuconf.h>
#undef STM32_I2C_USE_I2C1 #undef STM32_I2C_USE_I2C1
#define STM32_I2C_USE_I2C1 TRUE #define STM32_I2C_USE_I2C1 TRUE