From cd974d00c845f2a51ddb1b6cc60cc4d29d621180 Mon Sep 17 00:00:00 2001 From: Marek Schmitt <62243375+mawaeg@users.noreply.github.com> Date: Sat, 1 Mar 2025 16:52:01 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Drashna Jaelre --- keyboards/mawaeg/sharkropad/halconf.h | 2 +- keyboards/mawaeg/sharkropad/keyboard.json | 4 ++-- keyboards/mawaeg/sharkropad/keymaps/default/keymap.c | 2 +- keyboards/mawaeg/sharkropad/keymaps/default/rules.mk | 2 +- keyboards/mawaeg/sharkropad/mcuconf.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/keyboards/mawaeg/sharkropad/halconf.h b/keyboards/mawaeg/sharkropad/halconf.h index abf3acb6307..fbeb632aa7b 100755 --- a/keyboards/mawaeg/sharkropad/halconf.h +++ b/keyboards/mawaeg/sharkropad/halconf.h @@ -18,4 +18,4 @@ #define HAL_USE_I2C TRUE -#include_next \ No newline at end of file +#include_next diff --git a/keyboards/mawaeg/sharkropad/keyboard.json b/keyboards/mawaeg/sharkropad/keyboard.json index 44f6107ef5e..3082cef4532 100755 --- a/keyboards/mawaeg/sharkropad/keyboard.json +++ b/keyboards/mawaeg/sharkropad/keyboard.json @@ -8,7 +8,6 @@ }, "diode_direction": "COL2ROW", "encoder": { - "enabled": true, "rotary": [ {"pin_a": "A0", "pin_b": "A1"} ] @@ -17,6 +16,7 @@ "bootmagic": true, "command": false, "console": false, + "encoder": true, "extrakey": true, "mousekey": false, "nkro": true, @@ -118,7 +118,7 @@ "pin": "B3" }, "layouts": { - "LAYOUT_numpad_4x4": { + "LAYOUT": { "layout": [ {"matrix": [0, 3], "x": 3, "y": 0}, {"matrix": [1, 0], "x": 0, "y": 1}, diff --git a/keyboards/mawaeg/sharkropad/keymaps/default/keymap.c b/keyboards/mawaeg/sharkropad/keymaps/default/keymap.c index 5d8337076aa..02fd4a97019 100755 --- a/keyboards/mawaeg/sharkropad/keymaps/default/keymap.c +++ b/keyboards/mawaeg/sharkropad/keymaps/default/keymap.c @@ -29,7 +29,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { * │ 1 │ 2 │ 3 │ 0 │ * └───┴───┴───┴────────────┘ */ - [0] = LAYOUT_numpad_4x4( + [0] = LAYOUT( RGB_MOD, KC_P7, KC_P8, KC_P9, RGB_TOG, KC_P4, KC_P5, KC_P6, KC_NUM, diff --git a/keyboards/mawaeg/sharkropad/keymaps/default/rules.mk b/keyboards/mawaeg/sharkropad/keymaps/default/rules.mk index a40474b4d5c..ee325681483 100755 --- a/keyboards/mawaeg/sharkropad/keymaps/default/rules.mk +++ b/keyboards/mawaeg/sharkropad/keymaps/default/rules.mk @@ -1 +1 @@ -ENCODER_MAP_ENABLE = yes \ No newline at end of file +ENCODER_MAP_ENABLE = yes diff --git a/keyboards/mawaeg/sharkropad/mcuconf.h b/keyboards/mawaeg/sharkropad/mcuconf.h index a557cedb35f..3991841cb72 100755 --- a/keyboards/mawaeg/sharkropad/mcuconf.h +++ b/keyboards/mawaeg/sharkropad/mcuconf.h @@ -19,4 +19,4 @@ #include_next #undef STM32_I2C_USE_I2C1 -#define STM32_I2C_USE_I2C1 TRUE \ No newline at end of file +#define STM32_I2C_USE_I2C1 TRUE