gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-07-27 11:31:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Joel Challis <git@zvecr.com>
This commit is contained in:
Nick Brassel 2025-05-24 09:34:15 +10:00 committed by GitHub
parent 5920274d70
commit cb46402a5f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/faq_build.md
View File

@ -13,7 +13,7 @@ An example of using `sudo`, when your controller is ATMega32u4:
or just: or just:
$ qmk flash -kb <keyboard> -km <keymap> $ sudo make <keyboard>:<keymap>:flash
Note that running `make` with `sudo` is generally ***not*** a good idea, and you should use one of the former methods, if possible. Note that running `make` with `sudo` is generally ***not*** a good idea, and you should use one of the former methods, if possible.

16
lib/python/qmk/cli/doctor/check.py
View File

@ -17,18 +17,10 @@ class CheckStatus(Enum):
ESSENTIAL_BINARIES = { ESSENTIAL_BINARIES = {
'make': { 'make': {},
'version_arg': '--version' 'git': {},
}, 'dos2unix': {},
'git': { 'diff': {},
'version_arg': '--version'
},
'dos2unix': {
'version_arg': '--version'
},
'diff': {
'version_arg': '--version'
},
'dfu-programmer': {}, 'dfu-programmer': {},
'avrdude': {}, 'avrdude': {},
'dfu-util': {}, 'dfu-util': {},