From cb46402a5ff685d0c2d47f3d66beb81e86a6ff78 Mon Sep 17 00:00:00 2001 From: Nick Brassel Date: Sat, 24 May 2025 09:34:15 +1000 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Joel Challis --- docs/faq_build.md | 2 +- lib/python/qmk/cli/doctor/check.py | 16 ++++------------ 2 files changed, 5 insertions(+), 13 deletions(-) diff --git a/docs/faq_build.md b/docs/faq_build.md index 91831296b03..05cb3251c8e 100644 --- a/docs/faq_build.md +++ b/docs/faq_build.md @@ -13,7 +13,7 @@ An example of using `sudo`, when your controller is ATMega32u4: or just: - $ qmk flash -kb -km + $ sudo make ::flash Note that running `make` with `sudo` is generally ***not*** a good idea, and you should use one of the former methods, if possible. diff --git a/lib/python/qmk/cli/doctor/check.py b/lib/python/qmk/cli/doctor/check.py index 6ce6b1d8efd..80c4eec2f64 100644 --- a/lib/python/qmk/cli/doctor/check.py +++ b/lib/python/qmk/cli/doctor/check.py @@ -17,18 +17,10 @@ class CheckStatus(Enum): ESSENTIAL_BINARIES = { - 'make': { - 'version_arg': '--version' - }, - 'git': { - 'version_arg': '--version' - }, - 'dos2unix': { - 'version_arg': '--version' - }, - 'diff': { - 'version_arg': '--version' - }, + 'make': {}, + 'git': {}, + 'dos2unix': {}, + 'diff': {}, 'dfu-programmer': {}, 'avrdude': {}, 'dfu-util': {},