gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-07-28 03:51:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review feedback

Browse Source 
- Remove the config.h file from the idle_rgb_example keymap as the only
  settings was equal to the default
- Added empty endline to the end of idle_rgb_example/rules.mk and post_rules.mk
- Updated RGB_DEF custom keycode to QK_KB
This commit is contained in:
Isaac Rex 2025-05-03 09:11:44 -05:00
parent 556775dc4e
commit 88a27e6b8f
4 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h
View File

@ -1,6 +0,0 @@
// Copyright 2023 Isaac Rex (@Acliad)
// SPDX-License-Identifier: GPL-2.0-or-later
#pragma once
#define TAPPING_TERM 200

2
keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk
View File

@ -1,2 +1,2 @@
TAP_DANCE_ENABLE=yes
RGB_IDLE_ENABLE=yes
RGB_IDLE_ENABLE=yes

2
keyboards/nifty_numpad/nifty_numpad.h
View File

@ -36,7 +36,7 @@
*/
enum custom_keycodes {
RGB_DEF = QK_USER,
RGB_DEF = QK_KB,
RGB_IEF
};
#define LAYER_RGB (MAX_LAYER - 1)

2
keyboards/nifty_numpad/post_rules.mk
View File

@ -1,3 +1,3 @@
ifeq ($(strip $(RGB_IDLE_ENABLE)), yes)
OPT_DEFS += -DRGB_IDLE_ENABLE
endif
endif