From 88a27e6b8f3a0cf79809b573280de9def1c09a8a Mon Sep 17 00:00:00 2001 From: Isaac Rex Date: Sat, 3 May 2025 09:11:44 -0500 Subject: [PATCH] Address review feedback - Remove the config.h file from the idle_rgb_example keymap as the only settings was equal to the default - Added empty endline to the end of idle_rgb_example/rules.mk and post_rules.mk - Updated RGB_DEF custom keycode to QK_KB --- keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h | 6 ------ keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk | 2 +- keyboards/nifty_numpad/nifty_numpad.h | 2 +- keyboards/nifty_numpad/post_rules.mk | 2 +- 4 files changed, 3 insertions(+), 9 deletions(-) delete mode 100644 keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h diff --git a/keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h b/keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h deleted file mode 100644 index c5d7bd3037b..00000000000 --- a/keyboards/nifty_numpad/keymaps/idle_rgb_example/config.h +++ /dev/null @@ -1,6 +0,0 @@ -// Copyright 2023 Isaac Rex (@Acliad) -// SPDX-License-Identifier: GPL-2.0-or-later -#pragma once - -#define TAPPING_TERM 200 - diff --git a/keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk b/keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk index 0cd2ffc18cb..ed2895bd20b 100644 --- a/keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk +++ b/keyboards/nifty_numpad/keymaps/idle_rgb_example/rules.mk @@ -1,2 +1,2 @@ TAP_DANCE_ENABLE=yes -RGB_IDLE_ENABLE=yes \ No newline at end of file +RGB_IDLE_ENABLE=yes diff --git a/keyboards/nifty_numpad/nifty_numpad.h b/keyboards/nifty_numpad/nifty_numpad.h index 08d61609ebf..f625e3ef5da 100644 --- a/keyboards/nifty_numpad/nifty_numpad.h +++ b/keyboards/nifty_numpad/nifty_numpad.h @@ -36,7 +36,7 @@ */ enum custom_keycodes { - RGB_DEF = QK_USER, + RGB_DEF = QK_KB, RGB_IEF }; #define LAYER_RGB (MAX_LAYER - 1) diff --git a/keyboards/nifty_numpad/post_rules.mk b/keyboards/nifty_numpad/post_rules.mk index 92adb5051a6..be715cd22f9 100644 --- a/keyboards/nifty_numpad/post_rules.mk +++ b/keyboards/nifty_numpad/post_rules.mk @@ -1,3 +1,3 @@ ifeq ($(strip $(RGB_IDLE_ENABLE)), yes) OPT_DEFS += -DRGB_IDLE_ENABLE -endif \ No newline at end of file +endif