Apply suggestions from code review

Added all suggestions given by @dunk2k

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
This commit is contained in:
Kael Augusto 2023-10-16 09:18:04 -03:00 committed by GitHub
parent 4925d01dc1
commit 4f695ba3b5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 27 deletions

View File

@ -7,27 +7,3 @@
#define SERIAL_USART_TX_PIN B6 // USART TX pin #define SERIAL_USART_TX_PIN B6 // USART TX pin
#define SERIAL_USART_RX_PIN B7 // USART RX pin #define SERIAL_USART_RX_PIN B7 // USART RX pin
/*
* In case Kaly doesn't start with your computer, try adding these lines and
* flashing to the left half of your keyboard:
*/
//#define SPLIT_USB_TIMEOUT 10000
//#define SPLIT_USB_TIMEOUT_POLL 10
/*
* Feature disable options
* These options are also useful to firmware size reduction.
*/
/* disable debug print */
//#define NO_DEBUG
/* disable print */
//#define NO_PRINT
/* disable action features */
//#define NO_ACTION_LAYER
//#define NO_ACTION_TAPPING
//#define NO_ACTION_ONESHOT

View File

@ -2,7 +2,7 @@
"manufacturer": "Dwctor", "manufacturer": "Dwctor",
"keyboard_name": "kaly/kaly42", "keyboard_name": "kaly/kaly42",
"maintainer": "Dwctor", "maintainer": "Dwctor",
"bootloader": "stm32-dfu", "development_board": "blackpill_f401",
"features": { "features": {
"bootmagic": true, "bootmagic": true,
"command": false, "command": false,
@ -20,6 +20,7 @@
] ]
}, },
"split": { "split": {
"enabled": true,
"bootmagic": { "bootmagic": {
"matrix": [4, 5] "matrix": [4, 5]
}, },
@ -34,7 +35,6 @@
} }
} }
}, },
"processor": "STM32F401",
"url": "https://github.com/Dwctor/Kaly", "url": "https://github.com/Dwctor/Kaly",
"usb": { "usb": {
"device_version": "1.0.0", "device_version": "1.0.0",

View File

@ -1,2 +1 @@
SPLIT_KEYBOARD = yes
SERIAL_DRIVER = usart SERIAL_DRIVER = usart