From 4f695ba3b5debb1f59f732962ce2c4517b127739 Mon Sep 17 00:00:00 2001 From: Kael Augusto <45074062+Dwctor@users.noreply.github.com> Date: Mon, 16 Oct 2023 09:18:04 -0300 Subject: [PATCH] Apply suggestions from code review Added all suggestions given by @dunk2k Co-authored-by: Duncan Sutherland --- keyboards/kaly/kaly42/config.h | 24 ------------------------ keyboards/kaly/kaly42/info.json | 4 ++-- keyboards/kaly/kaly42/rules.mk | 1 - 3 files changed, 2 insertions(+), 27 deletions(-) diff --git a/keyboards/kaly/kaly42/config.h b/keyboards/kaly/kaly42/config.h index 0533b9b51ab..e97f0a8aa45 100644 --- a/keyboards/kaly/kaly42/config.h +++ b/keyboards/kaly/kaly42/config.h @@ -7,27 +7,3 @@ #define SERIAL_USART_TX_PIN B6 // USART TX pin #define SERIAL_USART_RX_PIN B7 // USART RX pin - -/* - * In case Kaly doesn't start with your computer, try adding these lines and - * flashing to the left half of your keyboard: - */ - -//#define SPLIT_USB_TIMEOUT 10000 -//#define SPLIT_USB_TIMEOUT_POLL 10 - -/* - * Feature disable options - * These options are also useful to firmware size reduction. - */ - -/* disable debug print */ -//#define NO_DEBUG - -/* disable print */ -//#define NO_PRINT - -/* disable action features */ -//#define NO_ACTION_LAYER -//#define NO_ACTION_TAPPING -//#define NO_ACTION_ONESHOT diff --git a/keyboards/kaly/kaly42/info.json b/keyboards/kaly/kaly42/info.json index cc8897843e0..b118e1e7942 100644 --- a/keyboards/kaly/kaly42/info.json +++ b/keyboards/kaly/kaly42/info.json @@ -2,7 +2,7 @@ "manufacturer": "Dwctor", "keyboard_name": "kaly/kaly42", "maintainer": "Dwctor", - "bootloader": "stm32-dfu", + "development_board": "blackpill_f401", "features": { "bootmagic": true, "command": false, @@ -20,6 +20,7 @@ ] }, "split": { + "enabled": true, "bootmagic": { "matrix": [4, 5] }, @@ -34,7 +35,6 @@ } } }, - "processor": "STM32F401", "url": "https://github.com/Dwctor/Kaly", "usb": { "device_version": "1.0.0", diff --git a/keyboards/kaly/kaly42/rules.mk b/keyboards/kaly/kaly42/rules.mk index 6bd8b9bf770..c6e29883213 100644 --- a/keyboards/kaly/kaly42/rules.mk +++ b/keyboards/kaly/kaly42/rules.mk @@ -1,2 +1 @@ -SPLIT_KEYBOARD = yes SERIAL_DRIVER = usart