Apply suggestions from code review

Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Joel Challis <git@zvecr.com>
This commit is contained in:
Akshay 2025-07-14 02:10:01 +05:30 committed by GitHub
parent 1a73d75316
commit 368ba1b6aa
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 8 deletions

View File

@ -37,7 +37,6 @@
"knight": true,
"christmas": true,
"static_gradient": true,
"rgb_test": true,
"alternating": true,
"twinkle": true
}

View File

@ -1,21 +1,26 @@
// Copyright 2025 Hawtkeys
// SPDX-License-Identifier: GPL-2.0-or-later
#include QMK_KEYBOARD_H
enum custom_keycodes {
LAYER_ROTATE = SAFE_RANGE,
};
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
[0] = LAYOUT(
LT(0,KC_NO),
LAYER_ROTATE,
KC_A, KC_B, KC_C
),
[1] = LAYOUT(
LT(0,KC_NO),
LAYER_ROTATE,
KC_1, KC_2, KC_3
),
[2] = LAYOUT(
LT(0,KC_NO),
LAYER_ROTATE,
KC_Q, KC_W, KC_E
),
[3] = LAYOUT(
LT(0,KC_NO),
LAYER_ROTATE,
KC_R, KC_T, KC_Y
)
};
@ -23,9 +28,9 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
#if defined(ENCODER_MAP_ENABLE)
const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = {
[0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) },
[1] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) },
[2] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) },
[3] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }
[1] = { ENCODER_CCW_CW(_______, _______) },
[2] = { ENCODER_CCW_CW(_______, _______) },
[3] = { ENCODER_CCW_CW(_______, _______) }
};
#endif