From 368ba1b6aa9248366a2e1f2488379f3351585c8a Mon Sep 17 00:00:00 2001 From: Akshay <32840608+axshae@users.noreply.github.com> Date: Mon, 14 Jul 2025 02:10:01 +0530 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Drashna Jaelre Co-authored-by: Joel Challis --- keyboards/hawtkeys/shortyk1/keyboard.json | 1 - .../shortyk1/keymaps/default/keymap.c | 19 ++++++++++++------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/keyboards/hawtkeys/shortyk1/keyboard.json b/keyboards/hawtkeys/shortyk1/keyboard.json index d52276604d0..f713067b722 100644 --- a/keyboards/hawtkeys/shortyk1/keyboard.json +++ b/keyboards/hawtkeys/shortyk1/keyboard.json @@ -37,7 +37,6 @@ "knight": true, "christmas": true, "static_gradient": true, - "rgb_test": true, "alternating": true, "twinkle": true } diff --git a/keyboards/hawtkeys/shortyk1/keymaps/default/keymap.c b/keyboards/hawtkeys/shortyk1/keymaps/default/keymap.c index 91c425370ea..c34afa53644 100644 --- a/keyboards/hawtkeys/shortyk1/keymaps/default/keymap.c +++ b/keyboards/hawtkeys/shortyk1/keymaps/default/keymap.c @@ -1,21 +1,26 @@ // Copyright 2025 Hawtkeys // SPDX-License-Identifier: GPL-2.0-or-later #include QMK_KEYBOARD_H + +enum custom_keycodes { + LAYER_ROTATE = SAFE_RANGE, +}; + const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { [0] = LAYOUT( - LT(0,KC_NO), + LAYER_ROTATE, KC_A, KC_B, KC_C ), [1] = LAYOUT( - LT(0,KC_NO), + LAYER_ROTATE, KC_1, KC_2, KC_3 ), [2] = LAYOUT( - LT(0,KC_NO), + LAYER_ROTATE, KC_Q, KC_W, KC_E ), [3] = LAYOUT( - LT(0,KC_NO), + LAYER_ROTATE, KC_R, KC_T, KC_Y ) }; @@ -23,9 +28,9 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { #if defined(ENCODER_MAP_ENABLE) const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][NUM_DIRECTIONS] = { [0] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, - [1] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, - [2] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, - [3] = { ENCODER_CCW_CW(KC_VOLD, KC_VOLU) } + [1] = { ENCODER_CCW_CW(_______, _______) }, + [2] = { ENCODER_CCW_CW(_______, _______) }, + [3] = { ENCODER_CCW_CW(_______, _______) } }; #endif