Apply suggestions from code review

post @zvecr suggestions

Co-authored-by: Joel Challis <git@zvecr.com>
This commit is contained in:
Silvino R. 2025-05-13 10:52:17 +10:00 committed by GitHub
parent b5eb8717c8
commit 1d00dfc5d9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 21 additions and 21 deletions

View File

@ -32,25 +32,25 @@
"layouts": { "layouts": {
"LAYOUT": { "LAYOUT": {
"layout": [ "layout": [
{"label": "Num Lock", "matrix": [0, 0], "x": 0, "y": 1, "hand": "R"}, {"matrix": [5, 0], "x": 2, "y": 0, "encoder":0},
{"label": "/", "matrix": [0, 1], "x": 1, "y": 1, "hand": "R"}, {"matrix": [5, 1], "x": 3, "y": 0, "encoder":1},
{"label": "*", "matrix": [0, 2], "x": 2, "y": 1, "hand": "R"}, {"label": "Num Lock", "matrix": [0, 0], "x": 0, "y": 1},
{"label": "-", "matrix": [0, 3], "x": 3, "y": 1, "hand": "R"}, {"label": "/", "matrix": [0, 1], "x": 1, "y": 1},
{"label": "7", "matrix": [1, 0], "x": 0, "y": 2, "hand": "R"}, {"label": "*", "matrix": [0, 2], "x": 2, "y": 1},
{"label": "8", "matrix": [1, 1], "x": 1, "y": 2, "hand": "R"}, {"label": "-", "matrix": [0, 3], "x": 3, "y": 1},
{"label": "9", "matrix": [1, 2], "x": 2, "y": 2, "hand": "R"}, {"label": "7", "matrix": [1, 0], "x": 0, "y": 2},
{"label": "+", "matrix": [1, 3], "x": 3, "y": 2, "h": 2, "hand": "R"}, {"label": "8", "matrix": [1, 1], "x": 1, "y": 2},
{"label": "4", "matrix": [2, 0], "x": 0, "y": 3, "hand": "R"}, {"label": "9", "matrix": [1, 2], "x": 2, "y": 2},
{"label": "5", "matrix": [2, 1], "x": 1, "y": 3, "hand": "R"}, {"label": "+", "matrix": [1, 3], "x": 3, "y": 2, "h": 2},
{"label": "6", "matrix": [2, 2], "x": 2, "y": 3, "hand": "R"}, {"label": "4", "matrix": [2, 0], "x": 0, "y": 3},
{"label": "1", "matrix": [3, 0], "x": 0, "y": 4, "hand": "R"}, {"label": "5", "matrix": [2, 1], "x": 1, "y": 3},
{"label": "2", "matrix": [3, 1], "x": 1, "y": 4, "hand": "R"}, {"label": "6", "matrix": [2, 2], "x": 2, "y": 3},
{"label": "3", "matrix": [3, 2], "x": 2, "y": 4, "hand": "R"}, {"label": "1", "matrix": [3, 0], "x": 0, "y": 4},
{"label": "Enter", "matrix": [3, 3], "x": 3, "y": 4, "h": 2, "hand": "R"}, {"label": "2", "matrix": [3, 1], "x": 1, "y": 4},
{"label": "0", "matrix": [4, 0], "x": 0, "y": 5, "w": 2, "hand": "R"}, {"label": "3", "matrix": [3, 2], "x": 2, "y": 4},
{"label": ".", "matrix": [4, 2], "x": 2, "y": 5, "hand": "R"}, {"label": "Enter", "matrix": [3, 3], "x": 3, "y": 4, "h": 2},
{"label": "", "matrix": [5, 0], "x": 2, "y": 0, "hand": "L"}, {"label": "0", "matrix": [4, 0], "x": 0, "y": 5, "w": 2},
{"label": "", "matrix": [5, 1], "x": 3, "y": 0, "hand": "L"}, {"label": ".", "matrix": [4, 2], "x": 2, "y": 5}
] ]
} }
} }

View File

@ -20,12 +20,12 @@
"keymap": "default", "keymap": "default",
"layers": [ "layers": [
[ [
"MO(1)", "KC_MUTE",
"KC_NUM", "KC_PSLS", "KC_PAST", "KC_PMNS", "KC_NUM", "KC_PSLS", "KC_PAST", "KC_PMNS",
"KC_P7", "KC_P8", "KC_P9", "KC_PPLS", "KC_P7", "KC_P8", "KC_P9", "KC_PPLS",
"KC_P4", "KC_P5", "KC_P6", "KC_P4", "KC_P5", "KC_P6",
"KC_P1", "KC_P2", "KC_P3", "KC_PENT", "KC_P1", "KC_P2", "KC_P3", "KC_PENT",
"KC_P0", "KC_PDOT", "KC_P0", "KC_PDOT"
"MO(1)", "KC_MUTE"
] ]
], ],
"layout": "LAYOUT", "layout": "LAYOUT",