From 1d00dfc5d9e5fe25bff9a70d525e81d4b89bbbe5 Mon Sep 17 00:00:00 2001 From: "Silvino R." <366673+silvinor@users.noreply.github.com> Date: Tue, 13 May 2025 10:52:17 +1000 Subject: [PATCH] Apply suggestions from code review post @zvecr suggestions Co-authored-by: Joel Challis --- keyboards/binepad/candypad/keyboard.json | 38 +++++++++---------- .../candypad/keymaps/default/keymap.json | 4 +- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/keyboards/binepad/candypad/keyboard.json b/keyboards/binepad/candypad/keyboard.json index 4fed86b0aea..c4e379e250a 100644 --- a/keyboards/binepad/candypad/keyboard.json +++ b/keyboards/binepad/candypad/keyboard.json @@ -32,25 +32,25 @@ "layouts": { "LAYOUT": { "layout": [ - {"label": "Num Lock", "matrix": [0, 0], "x": 0, "y": 1, "hand": "R"}, - {"label": "/", "matrix": [0, 1], "x": 1, "y": 1, "hand": "R"}, - {"label": "*", "matrix": [0, 2], "x": 2, "y": 1, "hand": "R"}, - {"label": "-", "matrix": [0, 3], "x": 3, "y": 1, "hand": "R"}, - {"label": "7", "matrix": [1, 0], "x": 0, "y": 2, "hand": "R"}, - {"label": "8", "matrix": [1, 1], "x": 1, "y": 2, "hand": "R"}, - {"label": "9", "matrix": [1, 2], "x": 2, "y": 2, "hand": "R"}, - {"label": "+", "matrix": [1, 3], "x": 3, "y": 2, "h": 2, "hand": "R"}, - {"label": "4", "matrix": [2, 0], "x": 0, "y": 3, "hand": "R"}, - {"label": "5", "matrix": [2, 1], "x": 1, "y": 3, "hand": "R"}, - {"label": "6", "matrix": [2, 2], "x": 2, "y": 3, "hand": "R"}, - {"label": "1", "matrix": [3, 0], "x": 0, "y": 4, "hand": "R"}, - {"label": "2", "matrix": [3, 1], "x": 1, "y": 4, "hand": "R"}, - {"label": "3", "matrix": [3, 2], "x": 2, "y": 4, "hand": "R"}, - {"label": "Enter", "matrix": [3, 3], "x": 3, "y": 4, "h": 2, "hand": "R"}, - {"label": "0", "matrix": [4, 0], "x": 0, "y": 5, "w": 2, "hand": "R"}, - {"label": ".", "matrix": [4, 2], "x": 2, "y": 5, "hand": "R"}, - {"label": "", "matrix": [5, 0], "x": 2, "y": 0, "hand": "L"}, - {"label": "", "matrix": [5, 1], "x": 3, "y": 0, "hand": "L"}, + {"matrix": [5, 0], "x": 2, "y": 0, "encoder":0}, + {"matrix": [5, 1], "x": 3, "y": 0, "encoder":1}, + {"label": "Num Lock", "matrix": [0, 0], "x": 0, "y": 1}, + {"label": "/", "matrix": [0, 1], "x": 1, "y": 1}, + {"label": "*", "matrix": [0, 2], "x": 2, "y": 1}, + {"label": "-", "matrix": [0, 3], "x": 3, "y": 1}, + {"label": "7", "matrix": [1, 0], "x": 0, "y": 2}, + {"label": "8", "matrix": [1, 1], "x": 1, "y": 2}, + {"label": "9", "matrix": [1, 2], "x": 2, "y": 2}, + {"label": "+", "matrix": [1, 3], "x": 3, "y": 2, "h": 2}, + {"label": "4", "matrix": [2, 0], "x": 0, "y": 3}, + {"label": "5", "matrix": [2, 1], "x": 1, "y": 3}, + {"label": "6", "matrix": [2, 2], "x": 2, "y": 3}, + {"label": "1", "matrix": [3, 0], "x": 0, "y": 4}, + {"label": "2", "matrix": [3, 1], "x": 1, "y": 4}, + {"label": "3", "matrix": [3, 2], "x": 2, "y": 4}, + {"label": "Enter", "matrix": [3, 3], "x": 3, "y": 4, "h": 2}, + {"label": "0", "matrix": [4, 0], "x": 0, "y": 5, "w": 2}, + {"label": ".", "matrix": [4, 2], "x": 2, "y": 5} ] } } diff --git a/keyboards/binepad/candypad/keymaps/default/keymap.json b/keyboards/binepad/candypad/keymaps/default/keymap.json index e4c7f66b6f1..adbbbb35795 100644 --- a/keyboards/binepad/candypad/keymaps/default/keymap.json +++ b/keyboards/binepad/candypad/keymaps/default/keymap.json @@ -20,12 +20,12 @@ "keymap": "default", "layers": [ [ + "MO(1)", "KC_MUTE", "KC_NUM", "KC_PSLS", "KC_PAST", "KC_PMNS", "KC_P7", "KC_P8", "KC_P9", "KC_PPLS", "KC_P4", "KC_P5", "KC_P6", "KC_P1", "KC_P2", "KC_P3", "KC_PENT", - "KC_P0", "KC_PDOT", - "MO(1)", "KC_MUTE" + "KC_P0", "KC_PDOT" ] ], "layout": "LAYOUT",