0
0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-04-26 17:11:28 +00:00

Apply suggestions from code review

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: jack <0x6a73@protonmail.com>
This commit is contained in:
Mark Stosberg 2024-06-10 21:50:42 -04:00 committed by Mark Stosberg
parent 8bd2c19129
commit 08d28e037b
No known key found for this signature in database
4 changed files with 2 additions and 29 deletions
keyboards/aki27/cocot46plus

View File

@ -56,8 +56,6 @@ enum cocot_keycodes {
#define SCRL_TO QK_USER_5 #define SCRL_TO QK_USER_5
#define SCRL_IN QK_USER_6 #define SCRL_IN QK_USER_6
bool encoder_update_user(uint8_t index, bool clockwise);
bool encoder_update_kb(uint8_t index, bool clockwise);
bool cocot_get_scroll_mode(void); bool cocot_get_scroll_mode(void);
void cocot_set_scroll_mode(bool mode); void cocot_set_scroll_mode(bool mode);

View File

@ -8,32 +8,19 @@
"pid": "0x0003", "pid": "0x0003",
"vid": "0x1727" "vid": "0x1727"
}, },
"processor": "atmega32u4", "development_board": "promicro",
"bootloader": "caterina",
"qmk": {
"locking": {
"enabled": false,
"resync": false
}
},
"build": { "build": {
"lto": true "lto": true
}, },
"features": { "features": {
"audio": false,
"backlight": false,
"bootmagic": true, "bootmagic": true,
"command": false,
"console": false,
"encoder":true, "encoder":true,
"extrakey": true, "extrakey": true,
"mousekey": true, "mousekey": true,
"nkro": false,
"oled": true, "oled": true,
"pointing_device": true, "pointing_device": true,
"rgblight": true "rgblight": true
}, },
"debounce": 5,
"matrix_pins": { "matrix_pins": {
"cols": ["F4", "F5", "F6", "F7", "B1", "B3"], "cols": ["F4", "F5", "F6", "F7", "B1", "B3"],
"rows": ["D4", "C6", "D7", "E6", "NO_PIN"], "rows": ["D4", "C6", "D7", "E6", "NO_PIN"],
@ -55,12 +42,9 @@
"ws2812": { "ws2812": {
"pin": "B6" "pin": "B6"
}, },
"tapping": {
"term": 200,
},
"encoder": { "encoder": {
"rotary": [ "rotary": [
{ "pin_a": "D3", "pin_b": "D2", "resolution": 4 } { "pin_a": "D3", "pin_b": "D2"}
] ]
}, },
"rgblight": { "rgblight": {
@ -73,9 +57,7 @@
"static_gradient": true, "static_gradient": true,
"twinkle": true, "twinkle": true,
}, },
"brightness_steps": 17,
"hue_steps": 10, "hue_steps": 10,
"saturation_steps": 17,
"max_brightness": 120, "max_brightness": 120,
}, },
"layouts": { "layouts": {

View File

@ -16,9 +16,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
*/ */
#include QMK_KEYBOARD_H #include QMK_KEYBOARD_H
#include <stdio.h>
#include "quantum.h"
// Defines names for use in layer keycodes and the keymap // Defines names for use in layer keycodes and the keymap
enum layer_number { enum layer_number {

View File

@ -1,6 +1,2 @@
# Not sure how to translate these into keyboard.json
SRC += matrix.c SRC += matrix.c
POINTING_DEVICE_DRIVER = adns5050 POINTING_DEVICE_DRIVER = adns5050
OLED_DRIVER = ssd1306