From 08d28e037bbb3f606ebd30c7fdcabeb42eed404d Mon Sep 17 00:00:00 2001
From: Mark Stosberg <mark@rideamigos.com>
Date: Mon, 10 Jun 2024 21:50:42 -0400
Subject: [PATCH] Apply suggestions from code review

Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: jack <0x6a73@protonmail.com>
---
 keyboards/aki27/cocot46plus/cocot46plus.h     |  2 --
 keyboards/aki27/cocot46plus/keyboard.json     | 22 ++-----------------
 .../cocot46plus/keymaps/default/keymap.c      |  3 ---
 keyboards/aki27/cocot46plus/rules.mk          |  4 ----
 4 files changed, 2 insertions(+), 29 deletions(-)

diff --git a/keyboards/aki27/cocot46plus/cocot46plus.h b/keyboards/aki27/cocot46plus/cocot46plus.h
index c22ea029fff..e0f530dff63 100644
--- a/keyboards/aki27/cocot46plus/cocot46plus.h
+++ b/keyboards/aki27/cocot46plus/cocot46plus.h
@@ -56,8 +56,6 @@ enum cocot_keycodes {
 #define SCRL_TO QK_USER_5
 #define SCRL_IN QK_USER_6
 
-bool encoder_update_user(uint8_t index, bool clockwise);
-bool encoder_update_kb(uint8_t index, bool clockwise);
 bool cocot_get_scroll_mode(void);
 void cocot_set_scroll_mode(bool mode);
 
diff --git a/keyboards/aki27/cocot46plus/keyboard.json b/keyboards/aki27/cocot46plus/keyboard.json
index 2e919547095..1a35be8a1e7 100644
--- a/keyboards/aki27/cocot46plus/keyboard.json
+++ b/keyboards/aki27/cocot46plus/keyboard.json
@@ -8,32 +8,19 @@
     "pid": "0x0003",
     "vid": "0x1727"
   },
-  "processor": "atmega32u4",
-  "bootloader": "caterina",
-  "qmk": {
-    "locking": {
-      "enabled": false,
-      "resync": false
-    }
-  },
+  "development_board": "promicro",
   "build": {
     "lto": true
   },
   "features": {
-    "audio": false,
-    "backlight": false,
     "bootmagic": true,
-    "command": false,
-    "console": false,
     "encoder":true,
     "extrakey": true,
     "mousekey": true,
-    "nkro": false,
     "oled": true,
     "pointing_device": true,
     "rgblight": true
   },
-  "debounce": 5,
   "matrix_pins": {
     "cols":  ["F4", "F5", "F6", "F7", "B1", "B3"],
     "rows": ["D4", "C6", "D7", "E6", "NO_PIN"],
@@ -55,12 +42,9 @@
   "ws2812": {
     "pin": "B6"
   },
-  "tapping": {
-    "term": 200,
-  },
   "encoder": {
     "rotary": [
-       { "pin_a": "D3", "pin_b": "D2", "resolution": 4 }
+       { "pin_a": "D3", "pin_b": "D2"}
     ]
   },
   "rgblight": {
@@ -73,9 +57,7 @@
       "static_gradient": true,
       "twinkle": true,
     },
-    "brightness_steps": 17,
     "hue_steps": 10,
-    "saturation_steps": 17,
     "max_brightness": 120,
   },
   "layouts": {
diff --git a/keyboards/aki27/cocot46plus/keymaps/default/keymap.c b/keyboards/aki27/cocot46plus/keymaps/default/keymap.c
index 55a2eda90b5..cb5f61f3266 100644
--- a/keyboards/aki27/cocot46plus/keymaps/default/keymap.c
+++ b/keyboards/aki27/cocot46plus/keymaps/default/keymap.c
@@ -16,9 +16,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include QMK_KEYBOARD_H
-#include <stdio.h>
-#include "quantum.h"
-
 
 // Defines names for use in layer keycodes and the keymap
 enum layer_number {
diff --git a/keyboards/aki27/cocot46plus/rules.mk b/keyboards/aki27/cocot46plus/rules.mk
index 67010d4a716..f92348b1dd3 100644
--- a/keyboards/aki27/cocot46plus/rules.mk
+++ b/keyboards/aki27/cocot46plus/rules.mk
@@ -1,6 +1,2 @@
-
-
-# Not sure how to translate these into keyboard.json
 SRC += matrix.c
 POINTING_DEVICE_DRIVER = adns5050
-OLED_DRIVER     = ssd1306