gitbot/twemoji
1
0
Fork 0
mirror of https://github.com/twitter/twemoji.git synced 2024-06-15 03:35:16 +00:00
Code Issues Projects Releases Wiki Activity

do not change nodes if not needed

Browse Source
This commit is contained in:
Andrea Giammarchi 2015-03-12 20:41:20 +00:00
parent 39a091da4b
commit 92d5bea1ab
5 changed files with 21 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
test.js
View File

@ -146,10 +146,7 @@ wru.test([{
div = document.createElement('div'); div = document.createElement('div');
div.appendChild(document.createTextNode('I \u2764\uFE0E emoji!')); div.appendChild(document.createTextNode('I \u2764\uFE0E emoji!'));
twemoji.parse(div); twemoji.parse(div);
wru.assert('default parsing created 3 nodes anyway', div.childNodes.length === 3); wru.assert('default parsing did NOT create 3 nodes anyway', div.childNodes.length === 1);
wru.assert('first child is the expected one', div.removeChild(div.firstChild).nodeValue === 'I ');
wru.assert('emoji child is unchanged', div.removeChild(div.firstChild).nodeValue === '\u2764\uFE0E');
wru.assert('last child is the expected one', div.removeChild(div.firstChild).nodeValue === ' emoji!');
} }
},{ },{
name: 'DOM parsing + size', name: 'DOM parsing + size',

7
twemoji-generator.js
View File

@ -604,6 +604,7 @@ function createTwemoji(re) {
var var
allText = grabAllTextNodes(node, []), allText = grabAllTextNodes(node, []),
length = allText.length, length = allText.length,
modified = false,
fragment, fragment,
subnode, subnode,
text, text,
@ -644,13 +645,15 @@ function createTwemoji(re) {
img.setAttribute('draggable', 'false'); img.setAttribute('draggable', 'false');
img.alt = alt; img.alt = alt;
img.src = src; img.src = src;
modified = true;
fragment.appendChild(img);
} }
} }
fragment.appendChild(img || createText(alt)); if (!img) fragment.appendChild(createText(alt));
img = null; img = null;
} }
// is there actually anything to replace in here ? // is there actually anything to replace in here ?
if (0 < i) { if (modified) {
// any text left to be added ? // any text left to be added ?
if (i < text.length) { if (i < text.length) {
fragment.appendChild( fragment.appendChild(

7
twemoji.amd.js
View File

@ -327,6 +327,7 @@ define(function () {
var var
allText = grabAllTextNodes(node, []), allText = grabAllTextNodes(node, []),
length = allText.length, length = allText.length,
modified = false,
fragment, fragment,
subnode, subnode,
text, text,
@ -367,13 +368,15 @@ define(function () {
img.setAttribute('draggable', 'false'); img.setAttribute('draggable', 'false');
img.alt = alt; img.alt = alt;
img.src = src; img.src = src;
modified = true;
fragment.appendChild(img);
} }
} }
fragment.appendChild(img || createText(alt)); if (!img) fragment.appendChild(createText(alt));
img = null; img = null;
} }
// is there actually anything to replace in here ? // is there actually anything to replace in here ?
if (0 < i) { if (modified) {
// any text left to be added ? // any text left to be added ?
if (i < text.length) { if (i < text.length) {
fragment.appendChild( fragment.appendChild(

7
twemoji.js
View File

@ -326,6 +326,7 @@ var twemoji = (function (
var var
allText = grabAllTextNodes(node, []), allText = grabAllTextNodes(node, []),
length = allText.length, length = allText.length,
modified = false,
fragment, fragment,
subnode, subnode,
text, text,
@ -366,13 +367,15 @@ var twemoji = (function (
img.setAttribute('draggable', 'false'); img.setAttribute('draggable', 'false');
img.alt = alt; img.alt = alt;
img.src = src; img.src = src;
modified = true;
fragment.appendChild(img);
} }
} }
fragment.appendChild(img || createText(alt)); if (!img) fragment.appendChild(createText(alt));
img = null; img = null;
} }
// is there actually anything to replace in here ? // is there actually anything to replace in here ?
if (0 < i) { if (modified) {
// any text left to be added ? // any text left to be added ?
if (i < text.length) { if (i < text.length) {
fragment.appendChild( fragment.appendChild(

7
twemoji.npm.js
View File

@ -327,6 +327,7 @@ var twemoji = (function (
var var
allText = grabAllTextNodes(node, []), allText = grabAllTextNodes(node, []),
length = allText.length, length = allText.length,
modified = false,
fragment, fragment,
subnode, subnode,
text, text,
@ -367,13 +368,15 @@ var twemoji = (function (
img.setAttribute('draggable', 'false'); img.setAttribute('draggable', 'false');
img.alt = alt; img.alt = alt;
img.src = src; img.src = src;
modified = true;
fragment.appendChild(img);
} }
} }
fragment.appendChild(img || createText(alt)); if (!img) fragment.appendChild(createText(alt));
img = null; img = null;
} }
// is there actually anything to replace in here ? // is there actually anything to replace in here ?
if (0 < i) { if (modified) {
// any text left to be added ? // any text left to be added ?
if (i < text.length) { if (i < text.length) {
fragment.appendChild( fragment.appendChild(