mirror of
https://github.com/qmk/qmk_firmware.git
synced 2024-11-22 11:29:26 +00:00
b1fbfaaacc
Although `keychron/c2_pro/ansi/rgb` and `keychron/c2_pro/ansi/white` use the same custom matrix code, the matrix layouts are slightly different; in particular, only the `keychron/c2_pro/ansi/white` board actually uses column 19. However, the handling of column 19 in the custom matrix code was broken, therefore that column did not work. Looks like the custom matrix code assumes that `SHIFT_COL_END` refers to the last column connected to the shift register, and not to the column past that; so the value of `SHIFT_COL_END` needs to be changed from 19 to 18 (columns 11...18 are connected to the shift register, and column 19 is connected to the C14 pin). Also the code which was determining `SIZE_T` and `UNSELECT_ALL_COL` had an off-by-one bug when counting the required number of bits (again due to the confusion on the `SHIFT_COL_END` meaning); this had been fixed too (the actual behavior of that part of the code did not change, because both the old and the new version select the 8 bit variant). |
||
|---|---|---|
| .. | ||
| c1_pro | ||
| c2_pro | ||
| common | ||
| q0 | ||
| q1 | ||
| q2 | ||
| q3 | ||
| q4 | ||
| q5 | ||
| q6 | ||
| q7 | ||
| q8 | ||
| q9 | ||
| q10 | ||
| q11 | ||
| q12 | ||
| q60 | ||
| q65 | ||
| s1 | ||
| v1 | ||
| v2 | ||
| v3 | ||
| v4 | ||
| v5 | ||
| v6 | ||
| v7 | ||
| v8 | ||
| v10 | ||