gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2024-12-11 04:10:58 +00:00
Code Issues Packages Projects Releases Wiki Activity
1fe4406f37
qmk_firmware/tool/mbed/mbed-sdk/CONTRIBUTING.md
Jun Wako 1fe4406f37 Squashed 'tmk_core/' changes from 7967731..b9e0ea0 
b9e0ea0 Merge commit '7fa9d8bdea3773d1195b04d98fcf27cf48ddd81d' as 'tool/mbed/mbed-sdk'
7fa9d8b Squashed 'tool/mbed/mbed-sdk/' content from commit 7c21ce5

git-subtree-dir: tmk_core
git-subtree-split: b9e0ea08cb940de20b3610ecdda18e9d8cd7c552
2015-04-24 16:26:14 +09:00

3.4 KiB
Raw Blame History

Description

This document is cheat sheet for everyone who wants to contribute to mbedmicro/mbed GitHub repository at GitHub. All changes in code base should originate from GitHub Issues and take advantage of existing GitHub flows. Goal is to attract contributors and allow them contribute to code and documentation at the same time.

Guidelines from this document are created to help new and existing contributors understand process workflow and align to project rules before pull request is submitted. It explains how a participant should do things like format code, test fixes, and submit patches.

Where to get more information?

You can for example read more in our docs section in mbedmicro/mbed/doc directory.

How to contribute

We really appreciate your contributions! We are Open Source project and we need your help. We want to keep it as easy as possible to contribute changes that get things working in your environment. There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.

Before a pull request will be merged, the mbed Contributor Agreement must be signed.

You can pick up existing mbed GitHub Issue and solve it or implement new feature you find important, attractive or just necessary. We will review your proposal via pull request mechanism, give you comments and merge your changes if we decide your contribution satisfy criteria such as quality.

Enhancements vs Bugs

Enhancements are:

  • New features implementation.
  • Code refactoring.
  • Coding rules, coding styles improvements.
  • Code comments improvement.
  • Documentation work.

Bugs are:

  • Issues rose internally or externally by mbedmicro/mbed users.
  • Internally (within mbed team) created issues from Continuous Integration pipeline and build servers.
  • Issues detected using automation tools such as compilers, sanitizers, static code analysis tools etc.

Gate Keeper role

Gate Keeper is a person responsible for GitHub process workflow execution and is responsible for repository / project code base. Gate Keeper is also responsible for code (pull request) quality stamp and approves or rejects code changes in project’s code base.

Gate Keepers will review your pull request code, give you comments in pull request comment section and in the end if everything goes well merge your pull request to one of our branches (most probably default master branch).

Please be patient, digest Gate Keeper's feedback and respond promptly :)

mbed SDK porting

Glossary

  • Gate Keeper – persons responsible for overall code-base quality of mbedmicro/mbed project.
  • Enhancement – New feature deployment, code refactoring actions or existing code improvements.
  • Bugfix – Issues originated from GitHub Issues pool, raised internally within mbed classic team or issues from automated code validators like linters, static code analysis tools etc.
  • Mbed classic – mbed SDK 2.0 located in GitHub at mbedmicro/mbed.