Review comments

.github/workflows/qmk_userspace_build.yml

@@ -27,17 +27,23 @@ jobs:
     - name: Checkout Userspace
       uses: actions/checkout@v3
       with:
-        path: userspace
         submodules: recursive
 
-    # This doesn't use actions/checkout as we want to allow qmk_firmware as a submodule
+    - name: Check qmk_firmware exists
+      id: check_files
+      uses: andstor/file-existence-action@v2
+      with:
+        files: qmk_firmware
+
     - name: Checkout QMK Firmware
-      run: |
-        if [ ! -d qmk_firmware ]; then
-          git clone -b ${{ inputs.qmk_ref || 'master' }} \
-            --depth=1000 --recurse-submodules --shallow-submodules \
-            https://github.com/${{ inputs.qmk_repo || 'qmk/qmk_firmware' }}.git
-        fi
+      uses: actions/checkout@v3
+      if: steps.check_files.outputs.files_exists == 'false'
+      with:
+        path: qmk_firmware
+        repository: ${{ inputs.qmk_repo || 'qmk/qmk_firmware' }}
+        ref: ${{ inputs.qmk_ref || 'master' }}
+        submodules: recursive
+        fetch-depth: 1000 # This line should be removed once userspace support exists in QMK Firmware
 
     ########################################################
     ## Delete this section once userspace exists upstream ##
@@ -61,7 +67,7 @@ jobs:
       run: |
         qmk config mass_compile.parallel=$(nproc 2>/dev/null || sysctl -n hw.ncpu 2>/dev/null || getconf _NPROCESSORS_ONLN 2>/dev/null)
         qmk config user.qmk_home=$GITHUB_WORKSPACE/qmk_firmware
-        qmk config user.overlay_dir=$GITHUB_WORKSPACE/userspace
+        qmk config user.overlay_dir=$GITHUB_WORKSPACE
 
     - name: Build
       run: |
@@ -75,14 +81,14 @@ jobs:
 
     - name: Upload binaries
       uses: actions/upload-artifact@v3
-      if: always()
+      if: always() && !cancelled()
       continue-on-error: true
       with:
         name: Firmware
         path: |
-          userspace/*.bin
-          userspace/*.hex
-          userspace/*.uf2
+          *.bin
+          *.hex
+          *.uf2
 
   publish:
     name: Publish
@@ -90,14 +96,19 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/download-artifact@v3
+    - name: Download binaries
+      if: always() && !cancelled()
+      uses: actions/download-artifact@v3
 
-    - uses: marvinpinto/action-automatic-releases@latest
-      if: always()
+    - name: Generate Release
+      uses: softprops/action-gh-release@v1
+      if: always() && !cancelled()
       with:
-        repo_token: "${{ github.token }}"
-        automatic_release_tag: "latest"
-        title: "Latest Firmware"
+        token: "${{ github.token }}"
+        name: Latest Firmware
+        tag_name: latest
+        fail_on_unmatched_files: false
+        draft: false
         prerelease: false
         files: |
           **/*.hex