gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-06-05 07:52:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add lint warning for empty url (#25182)

Browse Source
This commit is contained in:
Joel Challis 2025-04-21 20:07:05 +01:00 committed by GitHub
parent 2c54ff3e63
commit ec324af22e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lib/python/qmk/cli/lint.py
View File

@ -171,6 +171,14 @@ def _handle_invalid_features(kb, info):
return ok return ok
def _handle_invalid_config(kb, info):
"""Check for invalid keyboard level config
"""
if info.get('url') == "":
cli.log.warning(f'{kb}: Invalid keyboard level config detected - Optional field "url" should not be empty.')
return True
def _chibios_conf_includenext_check(target): def _chibios_conf_includenext_check(target):
"""Check the ChibiOS conf.h for the correct inclusion of the next conf.h """Check the ChibiOS conf.h for the correct inclusion of the next conf.h
""" """
@ -255,6 +263,9 @@ def keyboard_check(kb): # noqa C901
if not _handle_invalid_features(kb, kb_info): if not _handle_invalid_features(kb, kb_info):
ok = False ok = False
if not _handle_invalid_config(kb, kb_info):
ok = False
invalid_files = git_get_ignored_files(f'keyboards/{kb}/') invalid_files = git_get_ignored_files(f'keyboards/{kb}/')
for file in invalid_files: for file in invalid_files:
if 'keymap' in file: if 'keymap' in file: