gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-07-17 05:02:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Orient side LEDs on GMMK2 65% ANSI to match the rest of the matrix (#25402)

Browse Source 
Orient side LEDs on GMMK2 65% to match the rest of the matrix

On GMMK2 P65 ANSI, the side LEDs were mapped to the wrong sides
of the keyboard resulting in effects not being consistent with
the key surface. This was most jarring in effects like pinwheel
where the pattern involves the side LEDs and there is a distinctly
different flow on the left and right halves of the board.

This PR swaps the side LEDs in the map so that they are correctly
oriented. Applied to both ANSI and ISO variants.
This commit is contained in:
Andrew Litt 2025-06-23 17:01:56 -05:00 committed by GitHub
parent f5b02fbc11
commit de5fd5d4e2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 40 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
keyboards/gmmk/gmmk2/p65/ansi/ansi.c
View File

@ -204,26 +204,26 @@ led_config_t g_led_config = {{
{196, 64}, // 65 Down {196, 64}, // 65 Down
{210, 64}, // 66 Right {210, 64}, // 66 Right
{0, 0}, // 69 LED 1 {224, 0 }, // 69 LED 1
{0, 7}, // 70 LED 2 {224, 7 }, // 70 LED 2
{0, 14}, // 71 LED 3 {224, 14}, // 71 LED 3
{0, 21}, // 72 LED 4 {224, 21}, // 72 LED 4
{0, 28}, // 73 LED 5 {224, 28}, // 73 LED 5
{0, 35}, // 74 LED 6 {224, 35}, // 74 LED 6
{0, 42}, // 75 LED 7 {224, 42}, // 75 LED 7
{0, 49}, // 76 LED 8 {224, 49}, // 76 LED 8
{0, 56}, // 77 LED 9 {224, 56}, // 77 LED 9
{0, 64}, // 78 LED 10 {224, 64}, // 78 LED 10
{224, 0 }, // 79 LED 11 {0, 0 }, // 79 LED 11
{224, 7 }, // 80 LED 12 {0, 7 }, // 80 LED 12
{224, 14}, // 81 LED 13 {0, 14}, // 81 LED 13
{224, 21}, // 82 LED 14 {0, 21}, // 82 LED 14
{224, 28}, // 83 LED 15 {0, 28}, // 83 LED 15
{224, 35}, // 84 LED 16 {0, 35}, // 84 LED 16
{224, 42}, // 85 LED 17 {0, 42}, // 85 LED 17
{224, 49}, // 86 LED 18 {0, 49}, // 86 LED 18
{224, 56}, // 87 LED 19 {0, 56}, // 87 LED 19
{224, 64}, // 88 LED 20 {0, 64}, // 88 LED 20
}, { }, {
4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,
4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,

40
keyboards/gmmk/gmmk2/p65/iso/iso.c
View File

@ -206,26 +206,26 @@ led_config_t g_led_config = {{
{196, 64}, // 66 Down {196, 64}, // 66 Down
{210, 64}, // 67 Right {210, 64}, // 67 Right
{0, 0}, // 68 LED 1 {224, 0 }, // 68 LED 1
{0, 7}, // 69 LED 2 {224, 7 }, // 69 LED 2
{0, 14}, // 70 LED 3 {224, 14}, // 70 LED 3
{0, 21}, // 71 LED 4 {224, 21}, // 71 LED 4
{0, 28}, // 72 LED 5 {224, 28}, // 72 LED 5
{0, 35}, // 73 LED 6 {224, 35}, // 73 LED 6
{0, 42}, // 74 LED 7 {224, 42}, // 74 LED 7
{0, 49}, // 75 LED 8 {224, 49}, // 75 LED 8
{0, 56}, // 76 LED 9 {224, 56}, // 76 LED 9
{0, 64}, // 77 LED 10 {224, 64}, // 77 LED 10
{224, 0 }, // 78 LED 11 {0, 0 }, // 78 LED 11
{224, 7 }, // 79 LED 12 {0, 7 }, // 79 LED 12
{224, 14}, // 80 LED 13 {0, 14}, // 80 LED 13
{224, 21}, // 81 LED 14 {0, 21}, // 81 LED 14
{224, 28}, // 82 LED 15 {0, 28}, // 82 LED 15
{224, 35}, // 83 LED 16 {0, 35}, // 83 LED 16
{224, 42}, // 84 LED 17 {0, 42}, // 84 LED 17
{224, 49}, // 85 LED 18 {0, 49}, // 85 LED 18
{224, 56}, // 86 LED 19 {0, 56}, // 86 LED 19
{224, 64}, // 87 LED 20 {0, 64}, // 87 LED 20
}, { }, {
4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,
4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4, 4,