From cd173c714e841622eb24ac33fb6fda98f4175c94 Mon Sep 17 00:00:00 2001 From: t-ando Date: Thu, 4 Jul 2024 08:53:43 +0900 Subject: [PATCH] Corrected according to review --- keyboards/sepsepkbd/yubino_hara/keyboard.json | 13 ++++++------- .../sepsepkbd/yubino_hara/keymaps/default/keymap.c | 4 ---- .../sepsepkbd/yubino_hara/keymaps/via/keymap.c | 4 ---- keyboards/sepsepkbd/yubino_hara/readme.md | 6 +++--- 4 files changed, 9 insertions(+), 18 deletions(-) diff --git a/keyboards/sepsepkbd/yubino_hara/keyboard.json b/keyboards/sepsepkbd/yubino_hara/keyboard.json index 4055025510d..3efe0ee8a54 100644 --- a/keyboards/sepsepkbd/yubino_hara/keyboard.json +++ b/keyboards/sepsepkbd/yubino_hara/keyboard.json @@ -20,18 +20,12 @@ "sync": { "matrix_state": true } - }, - "usb_detect": { - "enabled": true } }, "matrix_pins": { "cols": ["GP1", "GP2", "GP3", "GP4", "GP5", "GP6", "GP7"], "rows": ["GP29", "GP28", "GP27", "GP26"] }, - "mouse_key": { - "enabled": true - }, "processor": "RP2040", "url": "", "usb": { @@ -47,7 +41,12 @@ "led_count": 44, "split": true, "split_count": [22, 22], - "sleep": true + "sleep": true, + "default": { + "hue": 0, + "sat": 0, + "val": 50 + } }, "layouts": { "LAYOUT_split_6x3_3_1": { diff --git a/keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c b/keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c index 3ee0e983b0d..0e5d1274bfd 100644 --- a/keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c +++ b/keyboards/sepsepkbd/yubino_hara/keymaps/default/keymap.c @@ -29,7 +29,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { _______, _______, _______, _______, _______, _______ ), }; - -void keyboard_post_init_user(void) { - rgblight_sethsv(0, 0, 50); -} diff --git a/keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c b/keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c index 0e5fd072850..2abb2c72476 100644 --- a/keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c +++ b/keyboards/sepsepkbd/yubino_hara/keymaps/via/keymap.c @@ -29,7 +29,3 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { _______, _______, _______, _______, _______, _______ ), }; - -void keyboard_post_init_user(void) { - rgblight_sethsv(0, 0, 100); -} diff --git a/keyboards/sepsepkbd/yubino_hara/readme.md b/keyboards/sepsepkbd/yubino_hara/readme.md index 1b90731f70d..66a843d6322 100644 --- a/keyboards/sepsepkbd/yubino_hara/readme.md +++ b/keyboards/sepsepkbd/yubino_hara/readme.md @@ -1,6 +1,6 @@ # yubino_hara -![yubino_hara](https://raw.githubusercontent.com/nagmeal/sep-sep-kbd/main/yubino-hara/yubinohara.jpg) +![yubino_hara](https://imgur.com/a/c91DXXL) - Split - Reverse tilt (tilted from front to back) @@ -16,11 +16,11 @@ Make example for this keyboard (after setting up your build environment): - qmk compile -kb sepsepkbd/yubino_hara -km default + make sepsepkbd/yubino_hara:default Flashing example for this keyboard: - Connect to PC with USB cable and copy the generated fa2 file. + make sepsepkbd/yubino_hara:default:flash See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).