From bb62c4ec6eca269ba279025073dbdc66acc61196 Mon Sep 17 00:00:00 2001 From: Dimitris Mantzouranis Date: Wed, 7 Jun 2023 00:46:32 +0300 Subject: [PATCH] qmk doctor: arm-none-eabi-gcc version check --- lib/python/qmk/cli/doctor/check.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lib/python/qmk/cli/doctor/check.py b/lib/python/qmk/cli/doctor/check.py index cd69cdd11c8..fe67a67387a 100644 --- a/lib/python/qmk/cli/doctor/check.py +++ b/lib/python/qmk/cli/doctor/check.py @@ -44,7 +44,13 @@ def _check_arm_gcc_version(): version_number = ESSENTIAL_BINARIES['arm-none-eabi-gcc']['output'].strip() cli.log.info('Found arm-none-eabi-gcc version %s', version_number) - return CheckStatus.OK # Right now all known arm versions are ok + parsed_version = _parse_gcc_version(version_number) + if parsed_version['minor'] < 3: + if parsed_version['major'] <= 10: + cli.log.warning('{fg_yellow}We do not recommend arm-none-eabi-gcc older than 10.3.x. Upgrading to 10.3.x or higher is recommended.') + return CheckStatus.WARNING + + return CheckStatus.OK # arm versions less than 10.3.x cause issues on sn32 def _check_avr_gcc_version():