gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-03-13 23:14:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure bit shifts are correct

Browse Source
This commit is contained in:
Jeremy Soller 2020-10-20 21:29:34 -06:00
parent f9a05c4997
commit b8dc165074
No known key found for this signature in database
GPG Key ID: E988B49EE78A7FB1
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
keyboards/system76/launch_beta_1/usb_mux.c
View File

@ -35,7 +35,8 @@ int usb7206_read_reg(struct USB7206 * self, uint32_t addr, uint8_t * data, int l
// Direction: 0 = write, 1 = read
0x01,
// Number of bytes to read from register
length,
//TODO: check length
length - 1,
// Register address byte 3
(uint8_t)(addr >> 24),
// Register address byte 2
@ -200,9 +201,9 @@ int usb7206_gpio_set(struct USB7206_GPIO * self, bool value) {
if (res < 0) return res;
if (value) {
data |= (1UL << self->pf);
data |= (((uint32_t)1) << self->pf);
} else {
data &= ~(1UL << self->pf);
data &= ~(((uint32_t)1) << self->pf);
}
return usb7206_write_reg_32(self->usb7206, PIO64_OUT, data);
}
@ -222,7 +223,7 @@ int usb7206_gpio_init(struct USB7206_GPIO * self) {
res = usb7206_read_reg_32(self->usb7206, PIO64_OEN, &data);
if (res < 0) return res;
data |= (1 << self->pf);
data |= (((uint32_t)1) << self->pf);
return usb7206_write_reg_32(self->usb7206, PIO64_OEN, data);
}