gitbot/qmk_firmware
0
0
Fork 0
mirror of https://github.com/qmk/qmk_firmware.git synced 2025-07-28 03:51:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

annepro2: apply suggestions from code review

Browse Source 
Co-authored-by: Joel Challis <git@zvecr.com>
This commit is contained in:
bwisn 2021-10-19 22:00:04 +02:00 committed by GitHub
parent 41a8091a08
commit af30f799d6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
keyboards/annepro2/annepro2.h
View File

@ -24,9 +24,6 @@ typedef struct __attribute__((__packed__)) {
uint8_t _dummy[10];
bool caps_lock;
} ble_capslock_t;
extern uint16_t annepro2LedMatrix[MATRIX_ROWS * MATRIX_COLS];
extern ble_capslock_t BLECapsLock;
// Matrix keymap
@ -62,3 +59,7 @@ enum AP2KeyCodes {
KC_AP_LED_SPEED,
AP2_SAFE_RANGE,
};
#undef SAFE_RANGE
#define SAFE_RANGE AP2_SAFE_RANGE

6
keyboards/annepro2/c15/config.h
View File

@ -23,17 +23,11 @@
#define DEVICE_VER 0x1337
#define MANUFACTURER Obins
#define PRODUCT Anne Pro 2 QMK
#define ANNEPRO2_C15
// key matrix size
#define MATRIX_ROWS 5
#define MATRIX_COLS 14
// layer size: MATRIX_ROWS * MATRIX_COLS * sizeof(uint16_t) = 144 bytes
// Number of supported layouts
#define NUM_LAYOUTS 4
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5

6
keyboards/annepro2/c18/config.h
View File

@ -23,17 +23,11 @@
#define DEVICE_VER 0x1337
#define MANUFACTURER Obins
#define PRODUCT Anne Pro 2(c18)QMK
#define ANNEPRO2_C18
// key matrix size
#define MATRIX_ROWS 5
#define MATRIX_COLS 14
// layer size: MATRIX_ROWS * MATRIX_COLS * sizeof(uint16_t) = 144 bytes
// Number of supported layouts
#define NUM_LAYOUTS 4
/* Debounce reduces chatter (unintended double-presses) - set 0 if debouncing is not needed */
#define DEBOUNCE 5

3
keyboards/annepro2/matrix.c
View File

@ -28,9 +28,6 @@
extern ioline_t row_list[MATRIX_ROWS];
extern ioline_t col_list[MATRIX_COLS];
void matrix_init_custom(void) {
}
bool matrix_scan_custom(matrix_row_t current_matrix[]) {
bool matrix_has_changed = false;
// cache of input ports for columns