From ad2eb9aa21f8b72617a0fb4b7f4149923e6b5db8 Mon Sep 17 00:00:00 2001 From: Marek Schmitt <62243375+mawaeg@users.noreply.github.com> Date: Sat, 8 Mar 2025 17:56:04 +0100 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Joel Challis --- keyboards/mawaeg/sharkropad/config.h | 2 ++ keyboards/mawaeg/sharkropad/keyboard.json | 2 +- keyboards/mawaeg/sharkropad/sharkropad.c | 9 +++++---- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/keyboards/mawaeg/sharkropad/config.h b/keyboards/mawaeg/sharkropad/config.h index 950f63860d0..da88e14a375 100644 --- a/keyboards/mawaeg/sharkropad/config.h +++ b/keyboards/mawaeg/sharkropad/config.h @@ -14,6 +14,8 @@ * along with this program. If not, see . */ +#pragma once + #define STM32_FLASH_SECTORS_PER_BANK 128 #define I2C1_SCL_PIN A9 diff --git a/keyboards/mawaeg/sharkropad/keyboard.json b/keyboards/mawaeg/sharkropad/keyboard.json index ee6715d3723..140fec46a24 100644 --- a/keyboards/mawaeg/sharkropad/keyboard.json +++ b/keyboards/mawaeg/sharkropad/keyboard.json @@ -103,7 +103,7 @@ {"x": 8, "y": 45, "flags": 2}, {"x": 8, "y": 17, "flags": 2} ], - "maximum_brightness": 180 + "max_brightness": 180 }, "url": "https://github.com/mawaeg/sharkropad", "usb": { diff --git a/keyboards/mawaeg/sharkropad/sharkropad.c b/keyboards/mawaeg/sharkropad/sharkropad.c index e7b23f2f41c..b5999d84059 100644 --- a/keyboards/mawaeg/sharkropad/sharkropad.c +++ b/keyboards/mawaeg/sharkropad/sharkropad.c @@ -75,7 +75,9 @@ return buf; } - bool oled_task_user(void) { +bool oled_task_kb(void) { + if (!oled_task_user()) { return false; } + static uint8_t last_effect = 0; static uint8_t last_speed = 0; static uint16_t key_timer = 0; @@ -120,6 +122,5 @@ oled_write("% ", false); } - return false; - } - \ No newline at end of file + return true; +}