From 60cac6d93811e931eea4438f04c2029d140afe96 Mon Sep 17 00:00:00 2001 From: Joel Challis Date: Tue, 6 Sep 2022 18:08:48 +0100 Subject: [PATCH 1/3] Discourage use of ENCODER_MAP at keyboard level (#18286) * Discourage use of ENCODER_MAP at keyboard level * Update docs/feature_encoders.md Co-authored-by: Ryan Co-authored-by: Ryan --- docs/feature_encoders.md | 4 +++- docs/pr_checklist.md | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/docs/feature_encoders.md b/docs/feature_encoders.md index fdde03ac233..2e4a4fe324f 100644 --- a/docs/feature_encoders.md +++ b/docs/feature_encoders.md @@ -69,7 +69,7 @@ Additionally, if one side does not have an encoder, you can specify `{}` for the ## Encoder map :id=encoder-map -Encoder mapping may be added to your `keymap.c`, which replicates the normal keyswitch layer handling functionality, but with encoders. Add this to your `rules.mk`: +Encoder mapping may be added to your `keymap.c`, which replicates the normal keyswitch layer handling functionality, but with encoders. Add this to your keymap's `rules.mk`: ```make ENCODER_MAP_ENABLE = yes @@ -88,6 +88,8 @@ const uint16_t PROGMEM encoder_map[][NUM_ENCODERS][2] = { #endif ``` +?> This should only be enabled at the keymap level. + ## Callbacks When not using `ENCODER_MAP_ENABLE = yes`, the callback functions can be inserted into your `.c`: diff --git a/docs/pr_checklist.md b/docs/pr_checklist.md index ae5cb5eef6d..1034631863b 100644 --- a/docs/pr_checklist.md +++ b/docs/pr_checklist.md @@ -67,6 +67,9 @@ https://github.com/qmk/qmk_firmware/pulls?q=is%3Apr+is%3Aclosed+label%3Akeyboard - no `(-/+size)` comments related to enabling features - remove the list of alternate bootloaders if one has been specified - no re-definitions of the default MCU parameters if same value, when compared to the equivalent MCU in [mcu_selection.mk](https://github.com/qmk/qmk_firmware/blob/master/builddefs/mcu_selection.mk) + - no "keymap only" features enabled + - `COMBO_ENABLE` + - `ENCODER_MAP_ENABLE` - keyboard `config.h` - don't repeat `MANUFACTURER` in the `PRODUCT` value - no `#define DESCRIPTION` From 7160487ccdd1ea6d07816290a95c42e49cc350ef Mon Sep 17 00:00:00 2001 From: James Young <18669334+noroadsleft@users.noreply.github.com> Date: Tue, 6 Sep 2022 10:36:37 -0700 Subject: [PATCH 2/3] Fungo rev1: fix QMK Configurator key sequence (#18293) * info.json: correct JSON syntax; friendly formatting * info.json: fix key sequence --- keyboards/fungo/rev1/info.json | 168 +++++++++++++++------------------ 1 file changed, 77 insertions(+), 91 deletions(-) diff --git a/keyboards/fungo/rev1/info.json b/keyboards/fungo/rev1/info.json index d34e95d5781..6941d70d815 100644 --- a/keyboards/fungo/rev1/info.json +++ b/keyboards/fungo/rev1/info.json @@ -11,101 +11,87 @@ "layouts": { "LAYOUT_fungo_split_num": { "layout": [ - {"x": 0, "y": 0.375}, - {"x": 1, "y": 0.375}, - {"x": 2, "y": 0.125}, - {"x": 3, "y": 0}, - {"x": 4, "y": 0.125}, - {"x": 5, "y": 0.25}, - {"x": 6, "y": 0.5}, + {"x":0, "y":0.375}, + {"x":1, "y":0.375}, + {"x":2, "y":0.125}, + {"x":3, "y":0}, + {"x":4, "y":0.125}, + {"x":5, "y":0.25}, + {"x":6, "y":0.5}, + {"x":12, "y":0.5}, + {"x":13, "y":0.25}, + {"x":14, "y":0.125}, + {"x":15, "y":0}, + {"x":16, "y":0.125}, + {"x":17, "y":0.375}, + {"x":18, "y":0.375}, - {"x": 12, "y": 0.5}, - {"x": 13, "y": 0.25}, - {"x": 14, "y": 0.125}, - {"x": 15, "y": 0}, - {"x": 16, "y": 0.125}, - {"x": 17, "y": 0.375}, - {"x": 18, "y": 0.375}, - + {"x":0, "y":1.375}, + {"x":1, "y":1.375}, + {"x":2, "y":1.125}, + {"x":3, "y":1}, + {"x":4, "y":1.125}, + {"x":5, "y":1.25}, + {"x":6, "y":1.5}, + {"x":12, "y":1.5}, + {"x":13, "y":1.25}, + {"x":14, "y":1.125}, + {"x":15, "y":1}, + {"x":16, "y":1.125}, + {"x":17, "y":1.375}, + {"x":18, "y":1.375}, - {"x": 0, "y": 1.375}, - {"x": 1, "y": 1.375}, - {"x": 2, "y": 1.125}, - {"x": 3, "y": 1}, - {"x": 4, "y": 1.125}, - {"x": 5, "y": 1.25}, - {"x": 6, "y": 1.5}, + {"x":0, "y":2.375}, + {"x":1, "y":2.375}, + {"x":2, "y":2.125}, + {"x":3, "y":2}, + {"x":4, "y":2.125}, + {"x":5, "y":2.25}, + {"x":6, "y":2.5}, + {"x":12, "y":2.5}, + {"x":13, "y":2.25}, + {"x":14, "y":2.125}, + {"x":15, "y":2}, + {"x":16, "y":2.125}, + {"x":17, "y":2.375}, + {"x":18, "y":2.375}, - {"x": 12, "y": 1.5}, - {"x": 13, "y": 1.25}, - {"x": 14, "y": 1.125}, - {"x": 15, "y": 1}, - {"x": 16, "y": 1.125}, - {"x": 17, "y": 1.375}, - {"x": 18, "y": 1.375}, - - {"x": 0, "y": 2.375}, - {"x": 1, "y": 2.375}, - {"x": 2, "y": 2.125}, - {"x": 3, "y": 2}, - {"x": 4, "y": 2.125}, - {"x": 5, "y": 2.25}, - {"x": 6, "y": 2.5}, + {"x":0, "y":3.375}, + {"x":1, "y":3.375}, + {"x":2, "y":3.125}, + {"x":3, "y":3}, + {"x":4, "y":3.125}, + {"x":5, "y":3.25}, + {"x":6, "y":3.5}, + {"x":7, "y":4}, + {"x":8.25, "y":3.75}, + {"x":9.75, "y":3.75}, + {"x":11, "y":4}, + {"x":12, "y":3.5}, + {"x":13, "y":3.25}, + {"x":14, "y":3.125}, + {"x":15, "y":3}, + {"x":16, "y":3.125}, + {"x":17, "y":3.375}, + {"x":18, "y":3.375}, - {"x": 12, "y": 2.5}, - {"x": 13, "y": 2.25}, - {"x": 14, "y": 2.125}, - {"x": 15, "y": 2}, - {"x": 16, "y": 2.125}, - {"x": 17, "y": 2.375}, - {"x": 18, "y": 2.375}, - - {"x": 0, "y": 3.375}, - {"x": 1, "y": 3.375}, - {"x": 2, "y": 3.125}, - {"x": 3, "y": 3}, - {"x": 4, "y": 3.125}, - {"x": 5, "y": 3.25}, - {"x": 6, "y": 3.5}, - - {"x": 12, "y": 3.5}, - {"x": 13, "y": 3.25}, - {"x": 14, "y": 3.125}, - {"x": 15, "y": 3}, - {"x": 16, "y": 3.125}, - {"x": 17, "y": 3.375}, - {"x": 18, "y": 3.375}, - - {"x": 0, "y": 4.375}, - {"x": 1, "y": 4.375}, - {"x": 2, "y": 4.25}, - {"x": 3, "y": 4.25}, - {"x": 5.25, "y": 3}, - {"x": 5.75, "y": 5}, - {"x": 7, "y": 4}, - - {"x": 11, "y": 4}, - {"x": 13.25, "y": 5}, - {"x": 13.75, "y": 3}, - {"x": 15, "y": 4.25}, - {"x": 16, "y": 4.25}, - {"x": 17, "y": 4.375}, - {"x": 18, "y": 4.375}, - - - {"x": 7, "y": 5}, - {"x": 8.25, "y": 3.75}, - {"x": 8.25, "y": 4.75}, - - {"x": 9.75, "y": 4.75}, - {"x": 9.75, "y": 3.75}, - {"x": 11, "y": 5}, - - - - - - ] + {"x":0, "y":4.375}, + {"x":1, "y":4.375}, + {"x":2, "y":4.25}, + {"x":3, "y":4.25}, + {"x":4.333, "y":4.25}, + {"x":5.667, "y":4.625}, + {"x":7, "y":5}, + {"x":8.25, "y":4.75}, + {"x":9.75, "y":4.75}, + {"x":11, "y":5}, + {"x":12.333, "y":4.625}, + {"x":13.667, "y":4.25}, + {"x":15, "y":4.25}, + {"x":16, "y":4.25}, + {"x":17, "y":4.375}, + {"x":18, "y":4.375} + ] } } } From f73330755153912f18619cfeaefe0270394e0daf Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Wed, 7 Sep 2022 00:13:12 +0200 Subject: [PATCH 3/3] keymaps/stapelberg: keypad layer for multimedia keys, wake on escape (#18295) This makes more keys function as printed on the actual keyboard :) --- keyboards/kinesis/keymaps/stapelberg/keymap.c | 30 +++++++++++++++++-- 1 file changed, 28 insertions(+), 2 deletions(-) diff --git a/keyboards/kinesis/keymaps/stapelberg/keymap.c b/keyboards/kinesis/keymaps/stapelberg/keymap.c index 431c9f234f4..9518c017bc0 100644 --- a/keyboards/kinesis/keymaps/stapelberg/keymap.c +++ b/keyboards/kinesis/keymaps/stapelberg/keymap.c @@ -17,6 +17,7 @@ #include QMK_KEYBOARD_H #define QWERTY 0 // Base qwerty +#define LAYER1 1 /**************************************************************************************************** @@ -56,7 +57,7 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { KC_LCTL,KC_LALT, KC_LGUI, KC_BSPC,KC_ESC ,KC_END , - KC_F9 ,KC_F10 ,KC_F11 ,KC_F12 ,KC_PSCR ,KC_SLCK ,KC_PAUS, KC_NO, QK_BOOT, + KC_F9 ,KC_F10 ,KC_F11 ,KC_F12 ,KC_PSCR ,KC_SLCK ,KC_PAUS, MO(1), QK_BOOT, KC_6 ,KC_7 ,KC_8 ,KC_9 ,KC_0 ,KC_MINS, KC_Y ,KC_U ,KC_I ,KC_O ,KC_P ,KC_BSLS, KC_H ,KC_J ,KC_K ,KC_L ,KC_SCLN,KC_QUOT, @@ -65,5 +66,30 @@ const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = { KC_RALT,KC_RCTL, KC_PGUP, KC_PGDN,KC_ENTER ,KC_SPC - ) + ), + +// LAYER1 is activated by the keypad key. It has WAKE on Escape (left-most key), +// and volume keys on PSCR (mute), SLCK (volume down) and PAUS (volume up), +// as printed on the Kinesis Advantage 2. +[LAYER1] = LAYOUT( + + KC_WAKE, KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO, + KC_NO , KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO , KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO , KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO , KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO , + KC_NO , + KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_MUTE ,KC_VOLD ,KC_VOLU, KC_TRNS, KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO ,KC_NO ,KC_NO , + KC_NO ,KC_NO , + KC_NO , + KC_NO ,KC_NO ,KC_NO + ), };