code review from lesshonor

This commit is contained in:
Xelus22 2023-11-30 15:52:30 +11:00
parent ac38d33523
commit 5bb14927ad
5 changed files with 5 additions and 11 deletions

View File

@ -9,8 +9,6 @@
"diode_direction": "COL2ROW",
"features": {
"bootmagic": true,
"command": false,
"console": false,
"extrakey": true,
"mousekey": true,
"nkro": true,

View File

@ -1,2 +0,0 @@
# The Default Valor Layout

View File

@ -1,2 +0,0 @@
# The VIA Valor Layout

View File

@ -8,7 +8,7 @@ An Alice replacement keyboard PCB.
Make example for this keyboard (after setting up your build environment):
make xelus/valor/rev3:default
make xelus/valor/rev3:default:flash
See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
@ -16,6 +16,6 @@ See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_to
Enter the bootloader in 3 ways:
* **Bootmagic reset**: Hold down the key at (0,0) in the matrix (usually the top left key or Escape) and plug in the keyboard
* **Physical reset button**: Briefly press the button on the back of the PCB - some may have pads you must short instead
* **Keycode in layout**: Press the key mapped to `QK_BOOT` if it is available
* **Bootmagic reset**: Hold down the top left key and plug in the keyboard
* **Physical Reset**: The AVR ISP is exposed. Short the RST pad with GND.
* **Keycode in layout**: Press the key mapped to `QK_BOOT`

View File

@ -1 +1 @@
# intentionally left blank
# This file intentionally left blank