From 3a025f41e08174b5f4f689adca67d1453bfe2be8 Mon Sep 17 00:00:00 2001 From: zvecr Date: Thu, 17 Jul 2025 00:42:12 +0100 Subject: [PATCH] Ensure keyboard aliases do not point to themselves --- lib/python/qmk/cli/ci/validate_aliases.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/python/qmk/cli/ci/validate_aliases.py b/lib/python/qmk/cli/ci/validate_aliases.py index 8b062dbe566..f891a599050 100644 --- a/lib/python/qmk/cli/ci/validate_aliases.py +++ b/lib/python/qmk/cli/ci/validate_aliases.py @@ -32,6 +32,10 @@ def ci_validate_aliases(cli): success = True for alias in aliases.keys(): target = aliases[alias].get('target', None) + if alias == target: + cli.log.error(f'Keyboard alias {alias} should not point to itself') + success = False + if not _target_keyboard_exists(target): cli.log.error(f'Keyboard alias {alias} has a target that doesn\'t exist: {target}') success = False