From 0342f6804be77ecbf7eb29878a268b95af54b769 Mon Sep 17 00:00:00 2001 From: sje Date: Sun, 25 Aug 2024 19:33:54 -0400 Subject: [PATCH] PR Comments --- keyboards/ibm/model_m/yacobo/keyboard.json | 5 ++--- keyboards/ibm/model_m/yacobo/readme.md | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/keyboards/ibm/model_m/yacobo/keyboard.json b/keyboards/ibm/model_m/yacobo/keyboard.json index a908e512f6b..7ea9c6a621c 100644 --- a/keyboards/ibm/model_m/yacobo/keyboard.json +++ b/keyboards/ibm/model_m/yacobo/keyboard.json @@ -2,7 +2,6 @@ "manufacturer": "IBM", "keyboard_name": "Model M (Yacobo)", "maintainer": "sje-mse", - "bootloader": "stm32duino", "diode_direction": "COL2ROW", "features": { "bootmagic": true, @@ -26,7 +25,7 @@ "rows": ["A1", "A2", "A3", "A4", "A5", "A6", "A7","B0"], "ghost": true }, - "processor": "STM32F103", + "development_board": "bluepill", "url": "https://github.com/sje-mse/yacobo", "usb": { "device_version": "1.0.0", @@ -281,6 +280,6 @@ {"label": "0", "matrix": [0, 11], "x": 19, "y": 5.5, "w": 2}, {"label": ".", "matrix": [0, 13], "x": 21, "y": 5.5} ] - } + } } } diff --git a/keyboards/ibm/model_m/yacobo/readme.md b/keyboards/ibm/model_m/yacobo/readme.md index 3a7e8968e57..d0cafa1d444 100644 --- a/keyboards/ibm/model_m/yacobo/readme.md +++ b/keyboards/ibm/model_m/yacobo/readme.md @@ -3,9 +3,7 @@ ![yacobo](https://i.imgur.com/1nfuWoa.jpeg) *A replacement qmk-compatible control board for the 101-key Model M keyboards. -Inspired by and based on the ModelH by jhawthorn, with the primary difference -being the use of 100% through-hole components (including the widely available -STM32F103C8T6 "Blue Pill" development board) for ease of assembly by hobbyists.* +Inspired by and based on the ModelH by jhawthorn, in comparison this design uses 100% through-hole components, including the widely available STM32F103C8T6 "Blue Pill" development board, for ease of assembly.* * Keyboard Maintainer: [Stephen Edwards](https://github.com/sje-mse) * Hardware Supported: IBM 101-key Model M with Yacobo replacement control boards.